]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: sched: fix memory leak in tcindex_partial_destroy_work
authorPavel Skripkin <paskripkin@gmail.com>
Sat, 17 Jul 2021 11:29:33 +0000 (14:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jul 2021 12:35:38 +0000 (14:35 +0200)
commit8e9662fde6d63c78eb1350f6167f64c9d71a865b
tree28e30e0023b075b0d89fdedff1b843b773af647e
parente14ef1095387f764d95614d3ec9e4d07c82a3533
net: sched: fix memory leak in tcindex_partial_destroy_work

[ Upstream commit f5051bcece50140abd1a11a2d36dc3ec5484fc32 ]

Syzbot reported memory leak in tcindex_set_parms(). The problem was in
non-freed perfect hash in tcindex_partial_destroy_work().

In tcindex_set_parms() new tcindex_data is allocated and some fields from
old one are copied to new one, but not the perfect hash. Since
tcindex_partial_destroy_work() is the destroy function for old
tcindex_data, we need to free perfect hash to avoid memory leak.

Reported-and-tested-by: syzbot+f0bbb2287b8993d4fa74@syzkaller.appspotmail.com
Fixes: 331b72922c5f ("net: sched: RCU cls_tcindex")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/cls_tcindex.c