]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: cleanup error checking on agent replies
authorMartin Kletzander <mkletzan@redhat.com>
Tue, 1 Apr 2014 12:58:56 +0000 (14:58 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 9 Apr 2014 16:35:01 +0000 (18:35 +0200)
commit8f69204d4aa589e4cc0771380cc7117eac4a3de7
tree0b61e76ac600dd7a3f89f7e4d2faf49751f2e49e
parent129862c58deba87c942116aea1e2a3a4bd19d34a
qemu: cleanup error checking on agent replies

On all the places where qemuAgentComand() was called, we did a check
for errors in the reply.  Unfortunately, some of the places called
qemuAgentCheckError() without checking for non-null reply which might
have resulted in a crash.

So this patch makes the error-checking part of qemuAgentCommand()
itself, which:

 a) makes it look better,

 b) makes the check mandatory and, most importantly,

 c) checks for the errors if and only if it is appropriate.

This actually fixes a potential crashers when qemuAgentComand()
returned 0, but reply was NULL.  Having said that, it *should* fix the
following bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1058149

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
(cherry picked from commit 5b3492fadb6bfddd370e263bf8a6953b1b26116f)

Conflicts:
src/qemu/qemu_agent.c -- vCPU functions (3099c063)
src/qemu/qemu_agent.c