]> git.ipfire.org Git - thirdparty/linux.git/commit
fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 16 Dec 2024 07:42:47 +0000 (08:42 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 17 Dec 2024 17:06:10 +0000 (18:06 +0100)
commit8fc38062be3f692ff8816da84fde71972530bcc4
tree3d69c9d3dddec1318ab129ef43bd04b6e0f515cc
parent9398332f23fab10c5ec57c168b44e72997d6318e
fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter
only controls backlight support within fbdev core code and data
structures.

Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users
select it explicitly. Fixes warnings about recursive dependencies,
such as

error: recursive dependency detected!
symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT
symbol FB_BACKLIGHT is selected by FB_SH_MOBILE_LCDC
symbol FB_SH_MOBILE_LCDC depends on FB_DEVICE
symbol FB_DEVICE depends on FB_CORE
symbol FB_CORE is selected by DRM_GEM_DMA_HELPER
symbol DRM_GEM_DMA_HELPER is selected by DRM_PANEL_ILITEK_ILI9341
symbol DRM_PANEL_ILITEK_ILI9341 depends on BACKLIGHT_CLASS_DEVICE

BACKLIGHT_CLASS_DEVICE is user-selectable, so making drivers adapt to
it is the correct approach in any case. For most drivers, backlight
support is also configurable separately.

v3:
- Select BACKLIGHT_CLASS_DEVICE in PowerMac defconfigs (Christophe)
- Fix PMAC_BACKLIGHT module dependency corner cases (Christophe)
v2:
- s/BACKLIGHT_DEVICE_CLASS/BACKLIGHT_CLASS_DEVICE (Helge)
- Fix fbdev driver-dependency corner case (Arnd)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20241216074450.8590-2-tzimmermann@suse.de
arch/powerpc/configs/pmac32_defconfig
arch/powerpc/configs/ppc6xx_defconfig
drivers/auxdisplay/Kconfig
drivers/macintosh/Kconfig
drivers/staging/fbtft/Kconfig
drivers/video/fbdev/Kconfig
drivers/video/fbdev/core/Kconfig