]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipv4: Mask upper DSCP bits and ECN bits in NETLINK_FIB_LOOKUP family
authorIdo Schimmel <idosch@nvidia.com>
Wed, 14 Aug 2024 12:52:22 +0000 (15:52 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 20 Aug 2024 12:57:07 +0000 (14:57 +0200)
commit8fed54758cd248cd311a2b5c1e180abef1866237
tree20aebbaac24850619d4180b42ef9676311c95473
parentccb445ae460e90b6864e5d77d72c42ae2b3cf377
ipv4: Mask upper DSCP bits and ECN bits in NETLINK_FIB_LOOKUP family

The NETLINK_FIB_LOOKUP netlink family can be used to perform a FIB
lookup according to user provided parameters and communicate the result
back to user space.

However, unlike other users of the FIB lookup API, the upper DSCP bits
and the ECN bits of the DS field are not masked, which can result in the
wrong result being returned.

Solve this by masking the upper DSCP bits and the ECN bits using
IPTOS_RT_MASK.

The structure that communicates the request and the response is not
exported to user space, so it is unlikely that this netlink family is
actually in use [1].

[1] https://lore.kernel.org/netdev/ZpqpB8vJU%2FQ6LSqa@debian/

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv4/fib_frontend.c