]> git.ipfire.org Git - people/ms/linux.git/commit
tcp: Fix integer-overflow in TCP vegas
authorChristoph Paasch <christoph.paasch@uclouvain.be>
Tue, 29 Jul 2014 11:40:57 +0000 (13:40 +0200)
committerWilly Tarreau <w@1wt.eu>
Sun, 23 Nov 2014 09:55:42 +0000 (10:55 +0100)
commit9063b87d25f1dbf3f3e0b91ab84b08b99b53ce4f
treeef5c1434a3af1b821a9ea4bf0b7d1acbac65843b
parent8b2de953aafa1fc799c0ca1e48ca615f884d9bc0
tcp: Fix integer-overflow in TCP vegas

[ Upstream commit 1f74e613ded11517db90b2bd57e9464d9e0fb161 ]

In vegas we do a multiplication of the cwnd and the rtt. This
may overflow and thus their result is stored in a u64. However, we first
need to cast the cwnd so that actually 64-bit arithmetic is done.

Then, we need to do do_div to allow this to be used on 32-bit arches.

Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Laight <David.Laight@ACULAB.COM>
Cc: Doug Leith <doug.leith@nuim.ie>
Fixes: 8d3a564da34e (tcp: tcp_vegas cong avoid fix)
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/ipv4/tcp_vegas.c