]> git.ipfire.org Git - thirdparty/samba.git/commit
smbd: Fix Coverity ID 1635770: avoid NULL deref of reparse
authorShachar Sharon <ssharon@redhat.com>
Thu, 5 Jun 2025 08:45:00 +0000 (11:45 +0300)
committerAnoop C S <anoopcs@samba.org>
Mon, 9 Jun 2025 06:26:05 +0000 (06:26 +0000)
commit91a3b8494f3176df5f5b97b52f497ff72f21bbe8
tree70ce89d5277bd091af1ce74e1388615fe4c3fa6c
parentff9178b6b4ad2aff651e7897aed5cf4fe7e37c20
smbd: Fix Coverity ID 1635770: avoid NULL deref of reparse

Commit 6d71edab5a ("smbd: use fsctl_get_reparse_point() in
smb3_file_posix_information_init()") introduced the local helper
function reparse_buffer_parse_posix_type; when this function enter the
case where 'reparse_tag != IO_REPARSE_TAG_NFS' the local variable
reparse is still NULL, and must not be de-referenced in DBG_INFO print.

Fixes Coverity issue 1635770

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Mon Jun  9 06:26:05 UTC 2025 on atb-devel-224
source3/smbd/smb2_posix.c