]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Heed lock protocol in DROP OWNED BY
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 6 May 2020 16:29:41 +0000 (12:29 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 6 May 2020 16:29:41 +0000 (12:29 -0400)
commit91d97462c96e07a6885261c9d46554b1c4ce834b
tree854808b0b8239b4d309fee07492af7da97416fff
parentad53d6efef0ca7ebc3f80531ecd230e5f28d638d
Heed lock protocol in DROP OWNED BY

We were acquiring object locks then deleting objects one by one, instead
of acquiring all object locks first, ignoring those that did not exist,
and then deleting all objects together.   The latter is the correct
protocol to use, and what this commits changes to code to do.  Failing
to follow that leads to "cache lookup failed for relation XYZ" error
reports when DROP OWNED runs concurrently with other DDL -- for example,
a session termination that removes some temp tables.

Author: Álvaro Herrera
Reported-by: Mithun Chicklore Yogendra (Mithun CY)
Reviewed-by: Ahsan Hadi, Tom Lane
Discussion: https://postgr.es/m/CADq3xVZTbzK4ZLKq+dn_vB4QafXXbmMgDP3trY-GuLnib2Ai1w@mail.gmail.com
src/backend/catalog/dependency.c
src/backend/catalog/pg_shdepend.c
src/include/catalog/dependency.h