]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nilfs2: prevent kernel bug at submit_bh_wbc()
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Wed, 13 Mar 2024 10:58:27 +0000 (19:58 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 10:50:07 +0000 (12:50 +0200)
commit91e4c4595fae5e87069e44687ae879091783c183
treed2e7230265930d12cc1c69ede08347dadef035d0
parent5c8f85e9ff21ee1fc6d20fcd73a15877556c3bbe
nilfs2: prevent kernel bug at submit_bh_wbc()

[ Upstream commit 269cdf353b5bdd15f1a079671b0f889113865f20 ]

Fix a bug where nilfs_get_block() returns a successful status when
searching and inserting the specified block both fail inconsistently.  If
this inconsistent behavior is not due to a previously fixed bug, then an
unexpected race is occurring, so return a temporary error -EAGAIN instead.

This prevents callers such as __block_write_begin_int() from requesting a
read into a buffer that is not mapped, which would cause the BUG_ON check
for the BH_Mapped flag in submit_bh_wbc() to fail.

Link: https://lkml.kernel.org/r/20240313105827.5296-3-konishi.ryusuke@gmail.com
Fixes: 1f5abe7e7dbc ("nilfs2: replace BUG_ON and BUG calls triggerable from ioctl")
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nilfs2/inode.c