]> git.ipfire.org Git - thirdparty/gcc.git/commit
Fix ICE with -fopt-info-inline (PR ipa/87955)
authorDavid Malcolm <dmalcolm@redhat.com>
Tue, 13 Nov 2018 15:59:57 +0000 (15:59 +0000)
committerDavid Malcolm <dmalcolm@gcc.gnu.org>
Tue, 13 Nov 2018 15:59:57 +0000 (15:59 +0000)
commit9228f64cc2ceb54764a302103e3b754c0b6235a2
tree74f795207b48d03aacd73cb423fc749de4062e8e
parentbe40afb2b93a0f8f5739dd36c3c804e6f809d1d4
Fix ICE with -fopt-info-inline (PR ipa/87955)

PR ipa/87955 reports a problem I introduced in r265920, where I converted
the guard in report_inline_failed_reason from using:
  if (dump_file)
to using
  if (dump_enabled_p ()).
without updating the calls to cl_target_option_print_diff and
cl_optimization_print_diff, which assume that dump_file is non-NULL.

The functions are auto-generated.  Rather than porting them to the dump
API, this patch applies the workaround of adding the missing checks on
dump_file before calling them.

gcc/ChangeLog:
PR ipa/87955
* ipa-inline.c (report_inline_failed_reason): Guard calls to
cl_target_option_print_diff and cl_optimization_print_diff with
if (dump_file).

gcc/testsuite/ChangeLog:
PR ipa/87955
* gcc.target/i386/pr87955.c: New test.

From-SVN: r266079
gcc/ChangeLog
gcc/ipa-inline.c
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.target/i386/pr87955.c [new file with mode: 0644]