]> git.ipfire.org Git - thirdparty/git.git/commit
pack-objects (mingw): demonstrate a segmentation fault with large deltas
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Tue, 16 Oct 2018 21:02:50 +0000 (14:02 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 19 Oct 2018 05:28:44 +0000 (14:28 +0900)
commit9308f45a9f1e3e107ba53a91d0f0c59342cb32bd
tree2d9aceb957f074f4b09cce85b5651b3fb69263c4
parentce498e094e8db32fff358ecf7e4ad4951e6bebce
pack-objects (mingw): demonstrate a segmentation fault with large deltas

There is a problem in the way 9ac3f0e5b3e4 (pack-objects: fix
performance issues on packing large deltas, 2018-07-22) initializes that
mutex in the `packing_data` struct. The problem manifests in a
segmentation fault on Windows, when a mutex (AKA critical section) is
accessed without being initialized. (With pthreads, you apparently do
not really have to initialize them?)

This was reported in https://github.com/git-for-windows/git/issues/1839.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5321-pack-large-objects.sh [new file with mode: 0755]