]> git.ipfire.org Git - thirdparty/qemu.git/commit
vdpa: reorder listener assignment
authorEugenio Pérez <eperezma@redhat.com>
Thu, 22 May 2025 14:58:37 +0000 (10:58 -0400)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 2 Jun 2025 18:29:15 +0000 (14:29 -0400)
commit9344dcbd004f951155c020d01c1bdc881e0451c1
treea0bf232580c1f0c5472ab4f775192b334d99c524
parentbe2e5fbefa7c1f8243bf6db2486b950b1ab19b72
vdpa: reorder listener assignment

Since commit f6fe3e333f ("vdpa: move memory listener to
vhost_vdpa_shared") this piece of code repeatedly assign
shared->listener members.  This was not a problem as it was not used
until device start.

However next patches move the listener registration to this
vhost_vdpa_init function.  When the listener is registered it is added
to an embedded linked list, so setting its members again will cause
memory corruption to the linked list node.

Do the right thing and only set it in the first vdpa device.

Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
Message-Id: <20250522145839.59974-6-jonah.palmer@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/vhost-vdpa.c