]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Distinguish route addition errors from route already exists
authorSelva Nair <selva.nair@gmail.com>
Fri, 6 Jan 2023 15:04:12 +0000 (10:04 -0500)
committerGert Doering <gert@greenie.muc.de>
Mon, 9 Jan 2023 11:56:34 +0000 (12:56 +0100)
commit93da80eaa1548197b173537bb74bf6db7e10912e
tree0d0a61711b7ea3039c686fb965c64ebeec727b20
parent9dd0bfb5983fdfbbb9e1fe2195642fbc4cc5f200
Distinguish route addition errors from route already exists

When possible, functions that add a route now return 1 on success,
or 2 if route already exists or 0 on other errors instead of true/false.

Note:
net_route_v4/v6_add using netlink filters out EEXIST before returning
this looks like a bug as add_route() and add_route_ipv6() should set
RT_ADDED only if route was really added.

v2: "succeeded/skipped" --> "succeeded" in log.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230106150412.1667492-1-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25903.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 9c6d72c783f4212f965e1e855b4fdb0ea34b595b)
src/openvpn/route.c
src/openvpn/route.h