]> git.ipfire.org Git - thirdparty/shadow.git/commit
Do not drop const qualifier for Basename
authorChristian Göttsche <cgzones@googlemail.com>
Mon, 3 Jan 2022 11:17:22 +0000 (12:17 +0100)
committerChristian Göttsche <cgzones@googlemail.com>
Mon, 3 Jan 2022 14:09:17 +0000 (15:09 +0100)
commit946eb8418244675b14efb9a5741963b6ee43a01c
treef8d9a68263b40db339ac54578e89c94c8843de8f
parent45bba0e190da77c16e503c308ef5dfa120cfd46b
Do not drop const qualifier for Basename

The private Basename() implementation does not modify its argument, so
a cast to a non-const char pointer is not necessary.

newgrp.c:790:39: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
  790 |         progbase = (char *) Basename ((char *) prog);
      |                                       ^
newgrp.c:790:20: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
  790 |         progbase = (char *) Basename ((char *) prog);
      |                    ^

shell.c:48:70: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   48 |                 (void) snprintf (arg0, sizeof arg0, "-%s", Basename ((char *) file));
      |                                                                      ^
libmisc/shell.c
src/newgrp.c