]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
serial: 8250: Use high-level writing function for FIFO
authorJohn Ogness <john.ogness@linutronix.de>
Tue, 7 Jan 2025 21:26:59 +0000 (22:32 +0106)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jan 2025 15:08:25 +0000 (16:08 +0100)
commit95a1b409ba08b602bf4464786ac74d21ae0acbf3
treebca4f2dea92068d46aa05aba0329f3e45724ec32
parent8d5cfb1fe5d8692b2de79b3831445be982167531
serial: 8250: Use high-level writing function for FIFO

Currently serial8250_console_fifo_write() directly writes into
the UART_TX register rather than using the high-level function
serial8250_console_putchar(). This is because
serial8250_console_putchar() waits for the holding register to
become empty, which would defeat the purpose of the FIFO code.

Move the LSR_THRE waiting to a new function
serial8250_console_wait_putchar() so that the FIFO code can use
serial8250_console_putchar(). This will be particularly important
for a follow-up commit, where output bytes are inspected to track
newlines.

This is only refactoring and has no functional change.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20250107212702.169493-4-john.ogness@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c