]> git.ipfire.org Git - thirdparty/linux.git/commit
usb: usb251xb: Add an empty hub' i2c-bus segment checker
authorSerge Semin <fancer.lancer@gmail.com>
Sat, 27 Apr 2019 09:06:44 +0000 (12:06 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Apr 2019 12:46:27 +0000 (14:46 +0200)
commit95e060e68bd98f28763adbc311797eebc4d31e0c
tree436b0f8d6298c13bf6dd2ec86cb74a2c257cc243
parenta4d6a2989dc3f2f2bcd25ca53dd187a1de68ffac
usb: usb251xb: Add an empty hub' i2c-bus segment checker

It's pointless to scan the hub' i2c-bus segment if GPIOs aren't supported
by the system, since no GPIO-driven reset could be cleared by the driver
then. Moreover if CONFIG_GPIOLIB is disabled the gpio_chip structure
definition won't be available, which causes the incomplete type pointer
dereference compilation error. In order to fix this we need to create an
empty usb251x_check_gpio_chip() method returning zero, so the driver would
skip the i2c-bus segment checking and proceed with further probing in this
case.

Fixes: 6e3c8beb4f92 ("usb: usb251xb: Lock i2c-bus segment the hub resides")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/usb251xb.c