]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net/sched: act_mpls: ensure LSE is pullable before reading it
authorDavide Caratti <dcaratti@redhat.com>
Thu, 3 Dec 2020 09:37:52 +0000 (10:37 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Dec 2020 19:13:37 +0000 (11:13 -0800)
commit9608fa653059c3f72faab0c148ac8773c46e7314
tree6ba66312b3eaa2d0439d397a6527ee5a3daccfe1
parent43c13605bad44b8abbc9776d6e63f62ccb7a47d6
net/sched: act_mpls: ensure LSE is pullable before reading it

when 'act_mpls' is used to mangle the LSE, the current value is read from
the packet dereferencing 4 bytes at mpls_hdr(): ensure that the label is
contained in the skb "linear" area.

Found by code inspection.

v2:
 - use MPLS_HLEN instead of sizeof(new_lse), thanks to Jakub Kicinski

Fixes: 2a2ea50870ba ("net: sched: add mpls manipulation actions to TC")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Guillaume Nault <gnault@redhat.com>
Link: https://lore.kernel.org/r/3243506cba43d14858f3bd21ee0994160e44d64a.1606987058.git.dcaratti@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/act_mpls.c