]> git.ipfire.org Git - thirdparty/squid.git/commit
Converity detected. inconsistent error detection on StoreIOBUffer
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 2 Oct 2008 12:24:09 +0000 (01:24 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 2 Oct 2008 12:24:09 +0000 (01:24 +1300)
commit967a359a71c5c35f4e40106e7334d97140eb332b
treee769834de134b9da08e489a37132cdb94e2cd369
parente77cac8b29092e2a4daf8c8888f05046d5e9f8a4
Converity detected. inconsistent error detection on StoreIOBUffer

Audit reveals only one of several callers which might set negative length
state were checking for it and setting error flag properly.

Makes more sense for the StoreIOBuffer constructor to do its own
error state detection with information than to offload on callers.
src/StoreIOBuffer.h
src/store_client.cc