]> git.ipfire.org Git - thirdparty/gcc.git/commit
Fix PR c++/66590: incorrect warning "reaches end of non-void function" for switch
authorAndrew Pinski <apinski@marvell.com>
Tue, 10 Aug 2021 01:33:17 +0000 (18:33 -0700)
committerAndrew Pinski <apinski@marvell.com>
Wed, 25 Aug 2021 21:27:18 +0000 (21:27 +0000)
commit971df602e0a798fe9c805c3105f4ac80d638a12b
treebc5980d86290425b79f79dc38698b5365b37aed3
parented3de423f1694d30f9cccc0c024fb6e19e2c6323
Fix PR c++/66590: incorrect warning "reaches end of non-void function" for switch

So the problem here is there is code in the C++ front-end not to add a
break statement (to the IR) if the previous block does not fall through.
The problem is the code which does the check to see if the block
may fallthrough does not check a CLEANUP_STMT; it assumes it is always
fall through.  Anyways this adds the code for the case of a CLEANUP_STMT
that is only for !CLEANUP_EH_ONLY (the try/finally case).

OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

gcc/cp/ChangeLog:

PR c++/66590
* cp-objcp-common.c (cxx_block_may_fallthru): Handle
CLEANUP_STMT for the case which will be try/finally.

gcc/testsuite/ChangeLog:

PR c++/66590
* g++.dg/warn/Wreturn-5.C: New test.
gcc/cp/cp-objcp-common.c
gcc/testsuite/g++.dg/warn/Wreturn-5.C [new file with mode: 0644]