]> git.ipfire.org Git - thirdparty/vuejs/core.git/commit
fix: should prefix `ShadowRoot` with `window.` (#2943)
authorHaoqun Jiang <haoqunjiang@gmail.com>
Wed, 3 Feb 2021 18:10:27 +0000 (02:10 +0800)
committerGitHub <noreply@github.com>
Wed, 3 Feb 2021 18:10:27 +0000 (19:10 +0100)
commit97d6f1a716045123d0e05600e64f11f92f504747
tree0facdd6bfaa9fcb64652d16268b80555424a2eeb
parent18b0c9a011b7569deae433fbbdf123764db2eae8
fix: should prefix `ShadowRoot` with `window.` (#2943)

Otherwise this expression would throw in environments that does not
support `ShadowRoot` which includes the common mocha testing environment
setup that uses `jsdom` and `jsdom-global`.

It is because `ShadowRoot` is not an enumerable property on `window`,
`jsdom-global` fails to expose it on the `global` object.

See the error message at: https://app.circleci.com/pipelines/github/vuejs/vue-cli/779/workflows/17d7d7c4-7605-4588-878a-ddb3a6d37102/jobs/24147
packages/runtime-dom/src/index.ts