]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: session: atomically increment the tracked sessions counter
authorWilly Tarreau <w@1wt.eu>
Tue, 16 Feb 2021 17:08:12 +0000 (18:08 +0100)
committerWilly Tarreau <w@1wt.eu>
Tue, 16 Feb 2021 17:08:12 +0000 (18:08 +0100)
commit9805859f245f4f59fc3baa098cb349786e21aaba
tree2cbb27cc49c291372f1ac55a9c73271569c6ddcd
parentaba507334b471e5b5d0044a74d7177b29491637f
BUG/MINOR: session: atomically increment the tracked sessions counter

In session_count_new() the tracked counter was still incremented with
a "++" outside of any lock, resulting in occasional slightly off values
such as the following:

    # table: foo, type: string, size:1000, used:1
    0xb2a398: key=127.1.2.3 use=0 exp=86398318 sess_cnt=999959 http_req_cnt=1000004

Now with the correct atomic increment:

    # table: foo, type: string, size:1000, used:1
    0x7f82a4026d38: key=127.1.2.3 use=0 exp=86399294 sess_cnt=1000004 http_req_cnt=1000004

This can be backported to 1.8.
src/session.c