]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open v9.1.0047
authorSean Dewar <seandewar@users.noreply.github.com>
Wed, 16 Aug 2023 13:17:36 +0000 (14:17 +0100)
committerChristian Brabandt <cb@256bit.org>
Tue, 23 Jan 2024 21:31:55 +0000 (22:31 +0100)
commit988f74311c26ea9917e84fbae608de226dba7e5f
tree95c475b5966ba8fac1f241e604d437bfed19c693
parent4927110a434e75f8f22188a95b366cfd1fa17e07
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open

Problem:  Things that temporarily change/restore curwin/buf (e.g:
          win_execute, some autocmds) may break assumptions that
          curwin/buf is the cmdwin when "cmdwin_type != 0", causing
          issues.

Solution: Expose the cmdwin's real win/buf and check that instead. Also
          try to ensure these variables are NULL if "cmdwin_type == 0",
          allowing them to be used directly in most cases without
          checking cmdwin_type. (Sean Dewar)

Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).

closes: #12819

Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
13 files changed:
src/drawline.c
src/drawscreen.c
src/evalwindow.c
src/ex_cmds.c
src/ex_getln.c
src/globals.h
src/gui.c
src/mouse.c
src/move.c
src/testdir/test_cmdwin.vim
src/textformat.c
src/version.c
src/window.c