]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_dahdi: Don't retry opening nonexistent channels on restart.
authorNaveen Albert <asterisk@phreaknet.org>
Tue, 26 Mar 2024 11:43:32 +0000 (07:43 -0400)
committerAsterisk Development Team <asteriskteam@digium.com>
Thu, 9 May 2024 13:56:11 +0000 (13:56 +0000)
commit98aa70cd382105da732b9404609791dec6f2e43b
treeb5e76cd9eecae2e31c9dddd2402f6d7c6f59f11d
parent855ed6c1685a265d74208ad284e5a6945afb9168
chan_dahdi: Don't retry opening nonexistent channels on restart.

Commit 729cb1d390b136ccc696430aa5c68d60ea4028be added logic to retry
opening DAHDI channels on "dahdi restart" if they failed initially,
up to 1,000 times in a loop, to address cases where the channel was
still in use. However, this retry loop does not use the actual error,
which means chan_dahdi will also retry opening nonexistent channels
1,000 times per channel, causing a flood of unnecessary warning logs
for an operation that will never succeed, with tens or hundreds of
thousands of open attempts being made.

The original patch would have been more targeted if it only retried
on the specific relevant error (likely EBUSY, although it's hard to
say since the original issue is no longer available).

To avoid the problem above while avoiding the possibility of breakage,
this skips the retry logic if the error is ENXIO (No such device or
address), since this will never succeed.

Resolves: #669
(cherry picked from commit 4e244528b398e959efb0085b9a2be63c1ee4a304)
channels/chan_dahdi.c