]> git.ipfire.org Git - thirdparty/postgresql.git/commit
TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
commit99aa0ff68a2cda3227732fdc722d8abd37ca035d
treeb5a3d0b6e66747ab757d60cc0cd25c924241408e
parentd696e63963d24cbd5c5715a331b70bfbffb2b113
TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded.  If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us
src/test/perl/PostgresNode.pm