]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: sg: fix static checker warning in sg_is_valid_dxfer
authorJohannes Thumshirn <jthumshirn@suse.de>
Mon, 17 Jul 2017 13:11:42 +0000 (15:11 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 11 Jun 2020 18:05:50 +0000 (19:05 +0100)
commit99b6d6fb8a7e74d56d17808556995822b7ae8eed
treec9dabb0e5cab2a12d588a727fd196628339a21a7
parent341068a66ab680ab19b4938253b872ca00ec8121
scsi: sg: fix static checker warning in sg_is_valid_dxfer

commit 14074aba4bcda3764c9a702b276308b89901d5b6 upstream.

dxfer_len is an unsigned int and we always assign a value > 0 to it, so
it doesn't make any sense to check if it is < 0. We can't really check
dxferp as well as we have both NULL and not NULL cases in the possible
call paths.

So just return true for SG_DXFER_FROM_DEV transfer in
sg_is_valid_dxfer().

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Colin Ian King <colin.king@canonical.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/sg.c