]> git.ipfire.org Git - thirdparty/postgresql.git/commit
initdb -S should now have an explicit check that $PGDATA is valid.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 May 2015 21:02:58 +0000 (17:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 May 2015 21:02:58 +0000 (17:02 -0400)
commit99f50dd720de59872bd842be3ec8eecea2be4b92
tree15796a72c5daad4653e9bd2eacc9945a5df4b243
parent70a4519b82beee9e7bffb17ae4e6d81bb3ab89d8
initdb -S should now have an explicit check that $PGDATA is valid.

The fsync code from the backend essentially assumes that somebody's already
validated PGDATA, at least to the extent of it being a readable directory.
That's safe enough for initdb's normal code path too, but "initdb -S"
doesn't have any other processing at all that touches the target directory.
To have reasonable error-case behavior, add a pg_check_dir call.
Per gripe from Peter E.
src/bin/initdb/initdb.c