]> git.ipfire.org Git - thirdparty/qemu.git/commit
9pfs: improve v9fs_open() tracing
authorChristian Schoenebeck <qemu_oss@crudebyte.com>
Fri, 3 Jan 2025 11:33:40 +0000 (12:33 +0100)
committerChristian Schoenebeck <qemu_oss@crudebyte.com>
Thu, 6 Feb 2025 16:10:46 +0000 (17:10 +0100)
commit9a0dd4b3e4e0b06ec35c5ac370f54a36ea1846ed
tree4512485ce20a7de796bdecbc55c675254105a1ed
parenta2f17bd40b3d302f6c1ddf0da75d2343966e0a3f
9pfs: improve v9fs_open() tracing

Improve tracing of 9p 'Topen' request type by showing open() flags as
human-readable text.

E.g. trace output:

  v9fs_open tag 0 id 12 fid 2 mode 100352

would become:

  v9fs_open tag=0 id=12 fid=2 mode=100352(RDONLY|NONBLOCK|DIRECTORY|
  TMPFILE|NDELAY)

Therefor add a new utility function qemu_open_flags_tostr() that converts
numeric open() flags from host's native O_* flag constants to a string
presentation.

9p2000.L and 9p2000.u protocol variants use different numeric 'mode'
constants for 'Topen' requests. Instead of writing string conversion code
for both protocol variants, use the already existing conversion functions
that convert the mode flags from respective protocol constants to host's
native open() numeric flag constants and pass that result to the new
string conversion function qemu_open_flags_tostr().

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <E1tTgDR-000oRr-9g@kylie.crudebyte.com>
hw/9pfs/9p-util-generic.c [new file with mode: 0644]
hw/9pfs/9p-util.h
hw/9pfs/9p.c
hw/9pfs/meson.build
hw/9pfs/trace-events