]> git.ipfire.org Git - thirdparty/linux.git/commit
ipv6: Set errno after ip_fib_metrics_init() in ip6_route_info_create().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 12 Mar 2025 01:38:48 +0000 (18:38 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 18 Mar 2025 11:58:08 +0000 (12:58 +0100)
commit9a81fc3480bf5dbe2bf80e278c440770f6ba2692
tree6b2f3b4b4ac72a9e0f0e7600421b7dc314dab712
parent9740890ee20e01f99ff1dde84c63dcf089fabb98
ipv6: Set errno after ip_fib_metrics_init() in ip6_route_info_create().

While creating a new IPv6, we could get a weird -ENOMEM when
RTA_NH_ID is set and either of the conditions below is true:

  1) CONFIG_IPV6_SUBTREES is enabled and rtm_src_len is specified
  2) nexthop_get() fails

e.g.)

  # strace ip -6 route add fe80::dead:beef:dead:beef nhid 1 from ::
  recvmsg(3, {msg_iov=[{iov_base=[...[
    {error=-ENOMEM, msg=[... [...]]},
    [{nla_len=49, nla_type=NLMSGERR_ATTR_MSG}, "Nexthops can not be used with so"...]
  ]], iov_len=32768}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, 0) = 148

Let's set err explicitly after ip_fib_metrics_init() in
ip6_route_info_create().

Fixes: f88d8ea67fbd ("ipv6: Plumb support for nexthop object in a fib6_info")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://patch.msgid.link/20250312013854.61125-1-kuniyu@amazon.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv6/route.c