]> git.ipfire.org Git - people/ms/linux.git/commit
ext4: revert commit which was causing fs corruption after journal replays
authorTheodore Ts'o <tytso@mit.edu>
Fri, 11 Jul 2014 17:55:40 +0000 (13:55 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jul 2014 23:23:16 +0000 (16:23 -0700)
commit9a87ea37bc551c2aecf978b55f8a78f71b7b80da
treed15404e7a83fefe5f7b829f643fcc028f76c9d36
parent480edc9475b340e0ff9077e3ef8f3e7e0be23196
ext4: revert commit which was causing fs corruption after journal replays

commit f9ae9cf5d72b3926ca48ea60e15bdbb840f42372 upstream.

Commit 007649375f6af2 ("ext4: initialize multi-block allocator before
checking block descriptors") causes the block group descriptor's count
of the number of free blocks to become inconsistent with the number of
free blocks in the allocation bitmap.  This is a harmless form of fs
corruption, but it causes the kernel to potentially remount the file
system read-only, or to panic, depending on the file systems's error
behavior.

Thanks to Eric Whitney for his tireless work to reproduce and to find
the guilty commit.

Fixes: 007649375f6af2 ("ext4: initialize multi-block allocator before checking block descriptors"
Reported-by: David Jander <david@protonic.nl>
Reported-by: Matteo Croce <technoboy85@gmail.com>
Tested-by: Eric Whitney <enwlinux@gmail.com>
Suggested-by: Eric Whitney <enwlinux@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/super.c