]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer
authorLu Yao <yaolu@kylinos.cn>
Thu, 23 Nov 2023 01:22:34 +0000 (09:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 22:52:27 +0000 (14:52 -0800)
commit9ad8b171c4e6ceb4fd80a9852b84ceace400edee
tree346f6fa4526a387358c4e6d438e40aa20503a4f5
parentf8eadbe713a3a74faa5fb179f53fb63d0439fa98
drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

[ Upstream commit 2161e09cd05a50d80736fe397145340d2e8f6c05 ]

For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init
'didt_rreg' and 'didt_wreg' to 'NULL'. But in func
'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT'
lacks of relevant judgment. And other 'amdgpu_ip_block_version' that use
these two definitions won't be added for 'AMDGPU_FAMILY_SI'.

So, add null pointer judgment before calling.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Lu Yao <yaolu@kylinos.cn>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c