]> git.ipfire.org Git - thirdparty/qemu.git/commit
block/export: Remove magic from block-export-add
authorKevin Wolf <kwolf@redhat.com>
Thu, 24 Sep 2020 15:26:53 +0000 (17:26 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 2 Oct 2020 13:46:40 +0000 (15:46 +0200)
commit9b562c646bc0ad5fca3cfa00720e431c7e72769a
tree59134ba5b6a31c3058328a7ddbf2540a8373c6e9
parentb57e4de079d90caca05fed5b45aeb642c6c29aa0
block/export: Remove magic from block-export-add

nbd-server-add tries to be convenient and adds two questionable
features that we don't want to share in block-export-add, even for NBD
exports:

1. When requesting a writable export of a read-only device, the export
   is silently downgraded to read-only. This should be an error in the
   context of block-export-add.

2. When using a BlockBackend name, unplugging the device from the guest
   will automatically stop the NBD server, too. This may sometimes be
   what you want, but it could also be very surprising. Let's keep
   things explicit with block-export-add. If the user wants to stop the
   export, they should tell us so.

Move these things into the nbd-server-add QMP command handler so that
they apply only there.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200924152717.287415-8-kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/export/export.c
blockdev-nbd.c
include/block/export.h
include/block/nbd.h
nbd/server.c
qemu-nbd.c