]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rcu/nocb: Fix possible invalid rdp's->nocb_cb_kthread pointer access
authorZqiang <qiang.zhang1211@gmail.com>
Wed, 7 May 2025 11:26:05 +0000 (19:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Aug 2025 16:41:11 +0000 (18:41 +0200)
commit9b5ec8e6b31755288a07b3abeeab8cd38e9d3c9d
tree4e2bb6b7a2a73a178e27a704010dbf6f0550ade2
parentf8aadf19786d672d5d148829e202b642185902aa
rcu/nocb: Fix possible invalid rdp's->nocb_cb_kthread pointer access

[ Upstream commit 1bba3900ca18bdae28d1b9fa10f16a8f8cb2ada1 ]

In the preparation stage of CPU online, if the corresponding
the rdp's->nocb_cb_kthread does not exist, will be created,
there is a situation where the rdp's rcuop kthreads creation fails,
and then de-offload this CPU's rdp, does not assign this CPU's
rdp->nocb_cb_kthread pointer, but this rdp's->nocb_gp_rdp and
rdp's->rdp_gp->nocb_gp_kthread is still valid.

This will cause the subsequent re-offload operation of this offline
CPU, which will pass the conditional check and the kthread_unpark()
will access invalid rdp's->nocb_cb_kthread pointer.

This commit therefore use rdp's->nocb_gp_kthread instead of
rdp_gp's->nocb_gp_kthread for safety check.

Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Neeraj Upadhyay (AMD) <neeraj.upadhyay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/rcu/tree_nocb.h