]> git.ipfire.org Git - people/ms/linux.git/commit
tracing/uprobes: Fix the usage of uprobe_buffer_enable() in probe_event_enable()
authorOleg Nesterov <oleg@redhat.com>
Fri, 27 Jun 2014 17:01:46 +0000 (19:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jul 2014 18:21:31 +0000 (11:21 -0700)
commit9b7954efb6d58c67a0504427a92f532412adc0fd
tree44862bd66930561b5a4b77f95aa41caf13ad1bb6
parentd197dca0ebbc2a93c8cffcd7ab15f40b69a9eb3a
tracing/uprobes: Fix the usage of uprobe_buffer_enable() in probe_event_enable()

commit fb6bab6a5ad46d00b5ffa22268f21df1cd7c59df upstream.

The usage of uprobe_buffer_enable() added by dcad1a20 is very wrong,

1. uprobe_buffer_enable() and uprobe_buffer_disable() are not balanced,
   _enable() should be called only if !enabled.

2. If uprobe_buffer_enable() fails probe_event_enable() should clear
   tp.flags and free event_file_link.

3. If uprobe_register() fails it should do uprobe_buffer_disable().

Link: http://lkml.kernel.org/p/20140627170146.GA18332@redhat.com
Acked-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Fixes: dcad1a204f72 "tracing/uprobes: Fetch args before reserving a ring buffer"
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/trace/trace_uprobe.c