]> git.ipfire.org Git - thirdparty/qemu.git/commit
esp: use correct type for esp_dma_enable() in sysbus_esp_gpio_demux()
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Wed, 13 Sep 2023 20:44:08 +0000 (21:44 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 3 Oct 2023 15:24:12 +0000 (18:24 +0300)
commit9b7feb87d0acfda5aff5b0830740ddc2d9ed7dcb
treee37e7e30544d5d913f4c5520abe5a506207b0312
parentae0b40d9d97f48040ffae4be7bcfebb5e5b17a5b
esp: use correct type for esp_dma_enable() in sysbus_esp_gpio_demux()

The call to esp_dma_enable() was being made with the SYSBUS_ESP type instead of
the ESP type. This meant that when GPIO 1 was being used to trigger a DMA
request from an external DMA controller, the setting of ESPState's dma_enabled
field would clobber unknown memory whilst the dma_cb callback pointer would
typically return NULL so the DMA request would never start.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230913204410.65650-2-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit b86dc5cb0b4105fa8ad29e822ab5d21c589c5ec5)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/scsi/esp.c