]> git.ipfire.org Git - people/arne_f/kernel.git/commit
platform/chrome: cros_ec_proto: check for NULL transfer function
authorEnrico Granata <egranata@chromium.org>
Wed, 3 Apr 2019 22:40:36 +0000 (15:40 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:54:55 +0000 (11:54 +0200)
commit9c8ace787b6f4bccc25eb2da7ada7c879d756bf2
treeb5ebdcec6bb79998b4d5947c1ca38f2110a0289a
parent147ee2cc1044c5cc8663cd19c78e356b521574d7
platform/chrome: cros_ec_proto: check for NULL transfer function

[ Upstream commit 94d4e7af14a1170e34cf082d92e4c02de9e9fb88 ]

As new transfer mechanisms are added to the EC codebase, they may
not support v2 of the EC protocol.

If the v3 initial handshake transfer fails, the kernel will try
and call cmd_xfer as a fallback. If v2 is not supported, cmd_xfer
will be NULL, and the code will end up causing a kernel panic.

Add a check for NULL before calling the transfer function, along
with a helpful comment explaining how one might end up in this
situation.

Signed-off-by: Enrico Granata <egranata@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/chrome/cros_ec_proto.c