]> git.ipfire.org Git - thirdparty/qemu.git/commit
aio: Fix return value of aio_poll()
authorKevin Wolf <kwolf@redhat.com>
Wed, 16 Jan 2013 18:25:51 +0000 (19:25 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 21 Jan 2013 19:23:52 +0000 (13:23 -0600)
commit9d173df5538a73cb8be53684ab19ea201c783663
tree217e70c1c4efbae80bd39a3ea29d1561123a73cf
parent204dd38c2da72687848d1a6fd2a81a8eaac6bf78
aio: Fix return value of aio_poll()

aio_poll() must return true if any work is still pending, even if it
didn't make progress, so that bdrv_drain_all() doesn't stop waiting too
early. The possibility of stopping early occasionally lead to a failed
assertion in bdrv_drain_all(), when some in-flight request was missed
and the function didn't really drain all requests.

In order to make that change, the return value as specified in the
function comment must change for blocking = false; fortunately, the
return value of blocking = false callers is only used in test cases, so
this change shouldn't cause any trouble.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit 2ea9b58f0bc62445b7ace2381b4c4db7d5597e19)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
aio-posix.c
aio-win32.c
qemu-aio.h
tests/test-aio.c