]> git.ipfire.org Git - thirdparty/qemu.git/commit
pcnet: fix possible buffer overflow
authorJason Wang <jasowang@redhat.com>
Wed, 30 May 2018 04:11:30 +0000 (12:11 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 27 Mar 2019 05:53:30 +0000 (00:53 -0500)
commit9d9430b75fd6e063d1f5a4d78228f21543458a44
tree0b1857bfb27ca8ae1bc97859040c0b9c946415f6
parentb3f1083edba68d5148fda042e195a51f75f1d8de
pcnet: fix possible buffer overflow

In pcnet_receive(), we try to assign size_ to size which converts from
size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access
for both buf and buf1.

Fixing by converting the type of size to size_t.

CC: qemu-stable@nongnu.org
Reported-by: Daniel Shapira <daniel@twistlock.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit b1d80d12c5f7ff081bb80ab4f4241d4248691192)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/net/pcnet.c