]> git.ipfire.org Git - thirdparty/qemu.git/commit
scsi-disk: Add warning comments that host_status errors take a shortcut
authorKevin Wolf <kwolf@redhat.com>
Wed, 31 Jul 2024 12:32:06 +0000 (14:32 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 10 Apr 2025 13:29:59 +0000 (16:29 +0300)
commit9da48f6f0fce18642e77498c592655669c1332e2
tree33bf20c9f53a1d42aff7088e75c0b0d99f77857c
parentf4c342a0797e119478ff3a583d75c2f0fe782399
scsi-disk: Add warning comments that host_status errors take a shortcut

scsi_block_sgio_complete() has surprising behaviour in that there are
error cases in which it directly completes the request and never calls
the passed callback. In the current state of the code, this doesn't seem
to result in bugs, but with future code changes, we must be careful to
never rely on the callback doing some cleanup until this code smell is
fixed. For now, just add warnings to make people aware of the trap.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20240731123207.27636-4-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 8a0495624f23f8f01dfb1484f367174f3b3572e8)
(Mjt: fix for e7fc3c4a8cc "scsi: remove outdated AioContext lock comment")
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/scsi/scsi-disk.c