]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.
authorNoah Misch <noah@leadboat.com>
Sun, 12 May 2019 17:33:05 +0000 (10:33 -0700)
committerNoah Misch <noah@leadboat.com>
Sun, 12 May 2019 17:34:22 +0000 (10:34 -0700)
commit9dc65bcf9dece8aa92f554db51112645c9751c9e
treec4a5516b9521df624d01fa0f31a17aff682fa768
parent899f943ca43ad2752e36a44c6ed9dd19cff02f69
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

The function had been interpreting SQL_ASCII messages as UTF8, throwing
an error when they were invalid UTF8.  The new behavior is consistent
with pg_do_encoding_conversion().  This affects LOG_DESTINATION_STDERR
and LOG_DESTINATION_EVENTLOG, which will send untranslated bytes to
write() and ReportEventA().  On buildfarm member bowerbird, enabling
log_connections caused an error whenever the role name was not valid
UTF8.  Back-patch to 9.4 (all supported versions).

Discussion: https://postgr.es/m/20190512015615.GD1124997@rfd.leadboat.com
src/backend/utils/mb/mbutils.c