]> git.ipfire.org Git - thirdparty/glibc.git/commit
Fix regex wctype namespace (bug 18495).
authorJoseph Myers <joseph@codesourcery.com>
Fri, 5 Jun 2015 20:04:47 +0000 (20:04 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Fri, 5 Jun 2015 20:04:47 +0000 (20:04 +0000)
commit9dd6b7799a0b04034f2d2266845c64a309b015a3
tree0ddf22dfc3d7d7f5b5aab3b6fe830d41075b9067
parenta330baa05bf827b67a6391721fa3ab2f72f1f4dc
Fix regex wctype namespace (bug 18495).

regcomp brings in references to various wctype functions that aren't
in all the standards including regcomp.  This patch fixes this in the
usual way by using the __* versions of these functions (which already
exist, but some didn't have libc_hidden_proto / libc_hidden_def
before).

Tested for x86_64 and x86 (testsuite, and that installed stripped
shared libraries are unchanged by the patch).  (Other wide character
function references from the regex code mean that this patch by itself
doesn't fix any XFAILed linknamespace test failures; further patches
will be needed for that.)

[BZ #18495]
* wctype/wcfuncs.c (__iswalnum): Use libc_hidden_def.
(__iswlower): Likewise.
* include/wctype.h (__iswalnum): Declare.  Use libc_hidden_proto.
(__iswlower): Likewise.
* posix/regcomp.c (re_compile_fastmap_iter): Call __towlower
instead of towlower.
* posix/regex_internal.c (build_wcs_upper_buffer): Call __iswlower
instead of iswlower.  Call __towupper instead of towupper.
* posix/regex_internal.h (IS_WIDE_WORD_CHAR): Call __iswalnum
instead of iswalnum.
ChangeLog
NEWS
include/wctype.h
posix/regcomp.c
posix/regex_internal.c
posix/regex_internal.h
wctype/wcfuncs.c