]> git.ipfire.org Git - thirdparty/FORT-validator.git/commit
Design 3 development checkpoint
authorAlberto Leiva Popper <ydahhrk@gmail.com>
Mon, 16 Sep 2024 18:43:21 +0000 (12:43 -0600)
committerAlberto Leiva Popper <ydahhrk@gmail.com>
Wed, 18 Sep 2024 18:08:12 +0000 (12:08 -0600)
commit9de06b67f7da2c54aa97a7d8c93eb2859baaecb9
treeca131d5417620ea3f0dea02a311e3290bbcb3986
parentc0b3a335e4dec8bb2ae366a425b717f33b5e8993
Design 3 development checkpoint

Sigh. The testing is forcing me to realize several misconceptions I've
been carrying.

Status:

This code is design 3. There are three refactors that clearly need to be
addressed immediately:

1. Design 3 is vulnerable to notification stack URL hacking, which has
   to be fixed by shifting to designs 3.1 or (unlikely) 4.
2. Fall back to rsync only on RRDP download failure; it's wasteful to
   also do it on RRDP validation failure.
3. Must commit repository content at the RPP level, not at the module
   level. (One failing RPP should not invalidate the whole module.)
28 files changed:
src/Makefile.am
src/cache.c
src/cachent.c
src/cachent.h
src/common.c
src/common.h
src/config.c
src/config.h
src/file.c
src/hash.c
src/http.c
src/log.c
src/log.h
src/main.c
src/object/certificate.c
src/object/tal.c
src/print_file.c
src/rrdp.c
src/rsync.c
src/types/map.c
src/types/path.c
src/types/path.h
test/Makefile.am
test/cache_test.c
test/cache_util.c
test/mock.c
test/rrdp_update_test.c
test/rrdp_util.h [new file with mode: 0644]