]> git.ipfire.org Git - thirdparty/glibc.git/commit
hurd: Use __hurd_fail () instead of assigning errno
authorSergey Bugaev <bugaevc@gmail.com>
Sat, 20 May 2023 11:55:29 +0000 (14:55 +0300)
committerSamuel Thibault <samuel.thibault@ens-lyon.org>
Sat, 20 May 2023 16:14:01 +0000 (18:14 +0200)
commit9ec31e57278ffc4e680ef03e75ce5b6b02e5edcf
tree458e020a274453bacf526e444594138ca67c36ef
parent36cc908ed549389713955093bbfeaa35fdaf3e2e
hurd: Use __hurd_fail () instead of assigning errno

The __hurd_fail () inline function is the dedicated, idiomatic way of
reporting errors in the Hurd part of glibc. Not only is it more concise
than '{ errno = err; return -1; }', it is since commit
6639cc10029e24e06b34e169712b21c31b8cf213
"hurd: Mark error functions as __COLD" marked with the cold attribute,
telling the compiler that this codepath is unlikely to be executed.

In one case, use __hurd_dfail () over the plain __hurd_fail ().

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230520115531.3911877-1-bugaevc@gmail.com>
49 files changed:
hurd/alloc-fd.c
hurd/fopenport.c
hurd/getdport.c
hurd/hurdselect.c
hurd/hurdsock.c
sysdeps/mach/hurd/brk.c
sysdeps/mach/hurd/closedir.c
sysdeps/mach/hurd/cthreads.c
sysdeps/mach/hurd/dirfd.c
sysdeps/mach/hurd/dl-sysdep.c
sysdeps/mach/hurd/dup3.c
sysdeps/mach/hurd/f_setlk.c
sysdeps/mach/hurd/fcntl.c
sysdeps/mach/hurd/fdopendir.c
sysdeps/mach/hurd/getcwd.c
sysdeps/mach/hurd/getegid.c
sysdeps/mach/hurd/getentropy.c
sysdeps/mach/hurd/geteuid.c
sysdeps/mach/hurd/getgid.c
sysdeps/mach/hurd/getlogin.c
sysdeps/mach/hurd/getlogin_r.c
sysdeps/mach/hurd/getrlimit.c
sysdeps/mach/hurd/getuid.c
sysdeps/mach/hurd/i386/sigreturn.c
sysdeps/mach/hurd/if_index.c
sysdeps/mach/hurd/ifreq.c
sysdeps/mach/hurd/libc_sigaction.c
sysdeps/mach/hurd/lseek.c
sysdeps/mach/hurd/mknodat.c
sysdeps/mach/hurd/mmap64.c
sysdeps/mach/hurd/opendir.c
sysdeps/mach/hurd/ptrace.c
sysdeps/mach/hurd/ptsname.c
sysdeps/mach/hurd/readdir.c
sysdeps/mach/hurd/readdir64.c
sysdeps/mach/hurd/readdir64_r.c
sysdeps/mach/hurd/sendmsg.c
sysdeps/mach/hurd/setrlimit.c
sysdeps/mach/hurd/sigaltstack.c
sysdeps/mach/hurd/sigpending.c
sysdeps/mach/hurd/sigprocmask.c
sysdeps/mach/hurd/sigsuspend.c
sysdeps/mach/hurd/spawni.c
sysdeps/mach/hurd/statconv.c
sysdeps/mach/hurd/statfsconv.c
sysdeps/mach/hurd/ttyname_r.c
sysdeps/mach/hurd/unlinkat.c
sysdeps/mach/hurd/waitid.c
sysdeps/mach/hurd/x86_64/sigreturn.c