]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemuxml2argvtest: Test expected error messages
authorSebastian Mitterle <smitterl@redhat.com>
Tue, 22 Sep 2020 11:57:39 +0000 (11:57 +0000)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 23 Sep 2020 20:47:59 +0000 (22:47 +0200)
commit9ec77eef2df973373b45e3c3faf52121fc1dfd67
tree95ce553ec422b541b33be22485cc42263ad082f9
parentafe26f76f2527ea1ccc9b00759f4dfe09f5cd191
qemuxml2argvtest: Test expected error messages

When an error is expected, the error message will be checked.
This is expressed by creating an additional ".err" file containing
the expected error message.

It is added in order to make sure the expected errors
are not masked by other errors during test execution while
leveraging the existing framework.

In order to keep it simple, an input file cannot be reused
anymore to cover several expected error cases configured
in the test code. An input file can still be reused by creating
a test case specific symlink.

For consistency, the mock needs to report an error now, too,
as every failure must have an error; otherwise a test case will
fail.

Require LC_ALL=C explicitly to make sure error messages are not
localized for testing.

Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
Suggested-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
222 files changed:
tests/qemuxml2argvdata/440fx-ide-address-conflict.err [new file with mode: 0644]
tests/qemuxml2argvdata/440fx-wrong-root.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-acpi-nouefi.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-features-sve-disabled.aarch64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-features-sve.aarch64-4.0.0.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-features-wrong.aarch64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-gic-host.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-gic-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-gic-not-arm.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-gic-not-virt.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-gic-v3.err [new file with mode: 0644]
tests/qemuxml2argvdata/aarch64-kvm-32-on-64.err [new file with mode: 0644]
tests/qemuxml2argvdata/boot-dev+order.err [new file with mode: 0644]
tests/qemuxml2argvdata/boot-menu-enable-with-timeout-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/boot-menu-enable-with-timeout.err [new file with mode: 0644]
tests/qemuxml2argvdata/chardev-reconnect-generated-path.err [new file with mode: 0644]
tests/qemuxml2argvdata/chardev-reconnect-invalid-timeout.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-cache-emulate-l2.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-cache-passthrough-l3.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-cache-passthrough3.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-host-model-nofallback.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-hotplug-granularity.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-nofallback.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-numa-disjoint.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-numa-memshared-1.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-numa-memshared-1.xml [new symlink]
tests/qemuxml2argvdata/cpu-numa-memshared.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-numa3.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-qemu-host-passthrough.err [new file with mode: 0644]
tests/qemuxml2argvdata/cpu-s390-features.err [new file with mode: 0644]
tests/qemuxml2argvdata/cputune-iothreadsched-toomuch.err [new file with mode: 0644]
tests/qemuxml2argvdata/cputune-vcpusched-overlap.err [new file with mode: 0644]
tests/qemuxml2argvdata/default-video-type-x86_64-caps-test-0.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-address-conflict.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-attaching-partition-nosupport.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-device-lun-type-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-fdc-incompatible-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-floppy-pseries.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-fmt-cow.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-fmt-dir.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-fmt-iso.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-hostdev-scsi-address-conflict.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-ide-incompatible-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-network-iscsi-auth-secrettype-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-network-iscsi-auth-wrong-secrettype.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-network-rbd-no-colon.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-network-source-auth-both.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-same-targets.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-sata-incompatible-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-scsi-disk-vpd-build-error.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-scsi-incompatible-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-shared-qcow.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-usb-nosupport.err [new file with mode: 0644]
tests/qemuxml2argvdata/disk-usb-pci.err [new file with mode: 0644]
tests/qemuxml2argvdata/graphics-sdl-egl-headless.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/graphics-spice-invalid-egl-headless.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-mdev-invalid-target-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-mdev-src-address-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-scsi-vhost-scsi-pci-boot-fail.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-subsys-mdev-vfio-ap-boot-fail.s390x-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-subsys-mdev-vfio-ccw-duplicate-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-subsys-mdev-vfio-ccw-invalid-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-subsys-mdev-vfio-ccw.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci-autogenerate-fids.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci-duplicate.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci-invalid-uid-valid-fid.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci-set-zero.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci-uid-set-zero.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci-wrong-arch.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdev-vfio-zpci.err [new file with mode: 0644]
tests/qemuxml2argvdata/hostdevs-drive-address-conflict.err [new file with mode: 0644]
tests/qemuxml2argvdata/hugepages-default-1G-nodeset-2M.err [new file with mode: 0644]
tests/qemuxml2argvdata/hugepages-memaccess-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/hugepages-memaccess3.err [new file with mode: 0644]
tests/qemuxml2argvdata/hugepages-nodeset-nonexist.err [new file with mode: 0644]
tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.err [new file with mode: 0644]
tests/qemuxml2argvdata/intel-iommu-wrong-machine.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/iothreads-nocap.err [new file with mode: 0644]
tests/qemuxml2argvdata/luks-disk-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/luks-disks-source-both.err [new file with mode: 0644]
tests/qemuxml2argvdata/luks-disks-source-qcow2.err [new file with mode: 0644]
tests/qemuxml2argvdata/mach-virt-serial-invalid-machine.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-aeskeywrap-off-cap.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-aeskeywrap-off-caps.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-aeskeywrap-on-cap.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-aeskeywrap-on-caps.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-deakeywrap-off-cap.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-deakeywrap-off-caps.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-deakeywrap-on-cap.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-deakeywrap-on-caps.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-loadparm-s390-char-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/machine-loadparm-s390-len-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/memory-align-fail.err [new file with mode: 0644]
tests/qemuxml2argvdata/memory-hotplug-nonuma.err [new file with mode: 0644]
tests/qemuxml2argvdata/minimal-no-memory.err [new file with mode: 0644]
tests/qemuxml2argvdata/misc-enable-s4.err [new file with mode: 0644]
tests/qemuxml2argvdata/missing-machine.err [new file with mode: 0644]
tests/qemuxml2argvdata/net-hostdev-fail.err [new file with mode: 0644]
tests/qemuxml2argvdata/net-vhostuser-fail.err [new file with mode: 0644]
tests/qemuxml2argvdata/net-vhostuser-multiq.err [new file with mode: 0644]
tests/qemuxml2argvdata/net-virtio-rxqueuesize-invalid-size.err [new file with mode: 0644]
tests/qemuxml2argvdata/net-virtio-teaming.err [new file with mode: 0644]
tests/qemuxml2argvdata/numad-auto-vcpu-static-numatune-no-nodeset.err [new file with mode: 0644]
tests/qemuxml2argvdata/numatune-memnode-no-memory.err [new file with mode: 0644]
tests/qemuxml2argvdata/numatune-memnode-nocpu.err [new file with mode: 0644]
tests/qemuxml2argvdata/numatune-memnode.err [new file with mode: 0644]
tests/qemuxml2argvdata/numatune-memnodes-problematic.err [new file with mode: 0644]
tests/qemuxml2argvdata/numatune-memory-invalid-nodeset.err [new file with mode: 0644]
tests/qemuxml2argvdata/numatune-static-nodeset-exceed-hostnode.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-bridge-duplicate-index.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-bridge-negative-index-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-bus-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-domain-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-expander-bus-bad-bus.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-expander-bus-bad-machine.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-expander-bus-bad-node.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-function-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-root-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-root-nonzero-index.err [new file with mode: 0644]
tests/qemuxml2argvdata/pci-slot-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/pcie-expander-bus-bad-bus.err [new file with mode: 0644]
tests/qemuxml2argvdata/pcie-expander-bus-bad-machine.err [new file with mode: 0644]
tests/qemuxml2argvdata/pcie-root-port-too-many.err [new file with mode: 0644]
tests/qemuxml2argvdata/pcihole64-none.err [new file with mode: 0644]
tests/qemuxml2argvdata/ppc64-tpm-double.err [new file with mode: 0644]
tests/qemuxml2argvdata/ppc64-tpmproxy-double.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-cpu-compat-power9.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-default-phb-numa-node.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-ccf.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-ccf.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-cfpc.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-cfpc.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-hpt-pagesize.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-htm.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-htm.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-htp-resize.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-htp-resize.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-ibs.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-ibs.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-invalid-machine.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-nested-hv.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-nested-hv.xml [new symlink]
tests/qemuxml2argvdata/pseries-features-sbbc.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-features-sbbc.xml [new symlink]
tests/qemuxml2argvdata/pseries-no-parallel.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-panic-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-phb-invalid-target-index-1.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-phb-invalid-target-index-2.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-phb-invalid-target-index-3.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-serial-invalid-machine.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-spaprvio-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/pseries-vio-address-clash.err [new file with mode: 0644]
tests/qemuxml2argvdata/q35-dmi-bad-address1.err [new file with mode: 0644]
tests/qemuxml2argvdata/q35-dmi-bad-address2.err [new file with mode: 0644]
tests/qemuxml2argvdata/q35-noacpi-uefi.err [new file with mode: 0644]
tests/qemuxml2argvdata/q35-wrong-root.err [new file with mode: 0644]
tests/qemuxml2argvdata/reboot-timeout-enabled.err [new file with mode: 0644]
tests/qemuxml2argvdata/s390-no-parallel.err [new file with mode: 0644]
tests/qemuxml2argvdata/s390-panic-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/seclabel-device-duplicates.err [new file with mode: 0644]
tests/qemuxml2argvdata/seclabel-multiple.err [new file with mode: 0644]
tests/qemuxml2argvdata/serial-unix-missing-source.err [new file with mode: 0644]
tests/qemuxml2argvdata/shmem-invalid-address.err [new file with mode: 0644]
tests/qemuxml2argvdata/shmem-invalid-size.err [new file with mode: 0644]
tests/qemuxml2argvdata/shmem-msi-only.err [new file with mode: 0644]
tests/qemuxml2argvdata/shmem-small-size.err [new file with mode: 0644]
tests/qemuxml2argvdata/shmem.err [new file with mode: 0644]
tests/qemuxml2argvdata/smbios-date.err [new file with mode: 0644]
tests/qemuxml2argvdata/smbios-uuid-match.err [new file with mode: 0644]
tests/qemuxml2argvdata/tpm-no-backend-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/tseg-explicit-size.x86_64-2.10.0.err [new file with mode: 0644]
tests/qemuxml2argvdata/tseg-i440fx.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/tseg-invalid-size.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-bus-missing.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-controller-default-unavailable-q35.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-controller-explicit-unavailable-q35.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-controller-qemu-xhci-limit.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-controller-qemu-xhci-unavailable.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-controller-xhci-limit.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-hub-conflict.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-hub-nonexistent.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-ich9-no-companion.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-none-hub.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-none-other.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-none-usbtablet.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-ports-out-of-range.err [new file with mode: 0644]
tests/qemuxml2argvdata/usb-too-long-port-path-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/vhost-user-fs-readonly.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/vhost_queues-invalid.err [new file with mode: 0644]
tests/qemuxml2argvdata/video-invalid-multiple-devices.err [new file with mode: 0644]
tests/qemuxml2argvdata/video-ramfb-display-device-pci-address.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-controller-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-controller-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-controller-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-disk-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-disk-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-disk-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-fs-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-fs-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-fs-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-input-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-input-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-input-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-memballoon-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-memballoon-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-memballoon-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-net-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-net-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-net-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-rng-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-rng-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-rng-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-video-ats.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-video-iommu.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-options-video-packed.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-rng-egd-crash.err [new file with mode: 0644]
tests/qemuxml2argvdata/virtio-transitional-not-supported.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvtest.c
tests/testutilsqemu.c
tests/testutilsqemu.h