]> git.ipfire.org Git - thirdparty/glibc.git/commit
Move math_opt_barrier, math_force_eval to separate math-barriers.h.
authorJoseph Myers <joseph@codesourcery.com>
Wed, 9 May 2018 19:45:47 +0000 (19:45 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Wed, 9 May 2018 19:45:47 +0000 (19:45 +0000)
commit9ed2e15ff4c9ff27c09103fa13a051e3605cbe5f
tree13e340bb8033848e46f825ee0489717436579b57
parent5460617d1567657621107d895ee2dd83bc1f88f2
Move math_opt_barrier, math_force_eval to separate math-barriers.h.

This patch continues cleaning up math_private.h by moving the
math_opt_barrier and math_force_eval macros to a separate header
math-barriers.h.

At present, those macros are inside a "#ifndef math_opt_barrier" in
math_private.h to allow architectures to override them and then use
a separate math-barriers.h header, no such #ifndef or #include_next is
needed; architectures just have their own alternative version of
math-barriers.h when providing their own optimized versions that avoid
going through memory unnecessarily.  The generic math-barriers.h has a
comment added to document these two macros.

In this patch, math_private.h is made to #include <math-barriers.h>,
so files using these macros do not need updating yet.  That is because
of uses of math_force_eval in math_check_force_underflow and
math_check_force_underflow_nonneg, which are still defined in
math_private.h.  Once those are moved out to a separate header, that
separate header can be made to include <math-barriers.h>, as can the
other files directly using these barrier macros, and then the include
of <math-barriers.h> from math_private.h can be removed.

Tested for x86_64 and x86.  Also tested with build-many-glibcs.py that
installed stripped shared libraries are unchanged by this patch.

* sysdeps/generic/math-barriers.h: New file.
* sysdeps/generic/math_private.h [!math_opt_barrier]
(math_opt_barrier): Move to math-barriers.h.
[!math_opt_barrier] (math_force_eval): Likewise.
* sysdeps/aarch64/fpu/math-barriers.h: New file.
* sysdeps/aarch64/fpu/math_private.h (math_opt_barrier): Move to
math-barriers.h.
(math_force_eval): Likewise.
* sysdeps/alpha/fpu/math-barriers.h: New file.
* sysdeps/alpha/fpu/math_private.h (math_opt_barrier): Move to
math-barriers.h.
(math_force_eval): Likewise.
* sysdeps/x86/fpu/math-barriers.h: New file.
* sysdeps/i386/fpu/fenv_private.h (math_opt_barrier): Move to
math-barriers.h.
(math_force_eval): Likewise.
* sysdeps/m68k/m680x0/fpu/math_private.h: Move to....
* sysdeps/m68k/m680x0/fpu/math-barriers.h: ... here.  Adjust
multiple-include guard for rename.
* sysdeps/powerpc/fpu/math-barriers.h: New file.
* sysdeps/powerpc/fpu/math_private.h (math_opt_barrier): Move to
math-barriers.h.
(math_force_eval): Likewise.
13 files changed:
ChangeLog
sysdeps/aarch64/fpu/math-barriers.h [new file with mode: 0644]
sysdeps/aarch64/fpu/math_private.h
sysdeps/alpha/fpu/math-barriers.h [new file with mode: 0644]
sysdeps/alpha/fpu/math_private.h
sysdeps/generic/math-barriers.h [new file with mode: 0644]
sysdeps/generic/math_private.h
sysdeps/i386/fpu/fenv_private.h
sysdeps/m68k/m680x0/fpu/math-barriers.h [new file with mode: 0644]
sysdeps/m68k/m680x0/fpu/math_private.h [deleted file]
sysdeps/powerpc/fpu/math-barriers.h [new file with mode: 0644]
sysdeps/powerpc/fpu/math_private.h
sysdeps/x86/fpu/math-barriers.h [new file with mode: 0644]