]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/tpm: TIS on sysbus: Remove unsupport ppi command line option
authorStefan Berger <stefanb@linux.ibm.com>
Thu, 13 Jul 2023 17:19:55 +0000 (13:19 -0400)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 13 Sep 2023 09:21:22 +0000 (12:21 +0300)
commit9eda3b687455f23ca77573edb79a4aca8a595b49
treec79f70d7c524ccd4de840d4203bd6ebc4aba4f21
parentb5fad36452586583858ddbbc2d085451cc79490a
hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

The ppi command line option for the TIS device on sysbus never worked
and caused an immediate segfault. Remove support for it since it also
needs support in the firmware and needs testing inside the VM.

Reproducer with the ppi=on option passed:

qemu-system-aarch64 \
   -machine virt,gic-version=3 \
   -m 4G  \
   -nographic -no-acpi \
   -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \
   -tpmdev emulator,id=tpm0,chardev=chrtpm \
   -device tpm-tis-device,tpmdev=tpm0,ppi=on
[...]
Segmentation fault (core dumped)

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20230713171955.149236-1-stefanb@linux.ibm.com
(cherry picked from commit 4c46fe2ed492f35f411632c8b5a8442f322bc3f0)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/tpm/tpm_tis_sysbus.c