]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: visor: Match I330 phone more precisely
authorJason A. Donenfeld <Jason@zx2c4.com>
Wed, 22 Apr 2015 12:35:09 +0000 (14:35 +0200)
committerZefan Li <lizefan@huawei.com>
Fri, 18 Sep 2015 01:20:38 +0000 (09:20 +0800)
commit9f0a120b3b1e639db798896039b2e5055c014ff5
tree83b770c079daec73a6ec9a5ba0457fe71b0fb508
parent6fc228600fa16a9666ac502eaa79137975feb105
USB: visor: Match I330 phone more precisely

commit 82ee3aeb9295c5fc37fd2ddf20f13ac2b40ec97d upstream.

Samsung has just released a portable USB3 SSD, coming in a very small
and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
already used by the Palm Visor driver for the Samsung I330 phone cradle.
Having pl2303 or visor pick up this device ID results in conflicts with
the usb-storage driver, which handles the newly released portable USB3
SSD.

To work around this conflict, I've dug up a mailing list post [1] from a
long time ago, in which a user posts the full USB descriptor
information. The most specific value in this appears to be the interface
class, which has value 255 (0xff). Since usb-storage requires an
interface class of 0x8, I believe it's correct to disambiguate the two
devices by matching on 0xff inside visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/usb/serial/visor.c