]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
test_firmware: fix setting old custom fw path back on exit, second try
authorBen Hutchings <ben.hutchings@codethink.co.uk>
Wed, 4 Apr 2018 20:38:49 +0000 (22:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 May 2018 07:53:10 +0000 (09:53 +0200)
commit9fd572f55c537ed0a80d8aec970e5c66db6c291f
treea54d1e59f68807b2abcc710fe188635a35d71278
parentc44b81bd7a47e0de466dc20f2d6febdf500cb007
test_firmware: fix setting old custom fw path back on exit, second try

commit e538409257d0217a9bc715686100a5328db75a15 upstream.

Commit 65c79230576 tried to clear the custom firmware path on exit by
writing a single space to the firmware_class.path parameter.  This
doesn't work because nothing strips this space from the value stored
and fw_get_filesystem_firmware() only ignores zero-length paths.

Instead, write a null byte.

Fixes: 0a8adf58475 ("test: add firmware_class loader test")
Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/firmware/fw_filesystem.sh