]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Initialize ListenSocket array earlier.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 29 Aug 2023 06:09:40 +0000 (09:09 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 29 Aug 2023 06:12:17 +0000 (09:12 +0300)
commita01e479e84837cfdfae4a9b062b97ce1a261a96c
tree724b2c4a1d3ec58bc101a7559a3a7e59564d7aee
parent27566bcf3c875a7a75c4f5eac76324f2fe24edda
Initialize ListenSocket array earlier.

After commit b0bea38705, syslogger prints 63 warnings about failing to
close a listen socket at postmaster startup. That's because the
syslogger process forks before the ListenSockets array is initialized,
so ClosePostmasterPorts() calls "close(0)" 64 times. The first call
succeeds, because fd 0 is stdin.

This has been like this since commit 9a86f03b4e in version 13, which
moved the SysLogger_Start() call to before initializing ListenSockets.
We just didn't notice until commit b0bea38705 added the LOG message.

Reported by Michael Paquier and Jeff Janes.

Author: Michael Paquier
Discussion: https://www.postgresql.org/message-id/ZOvvuQe0rdj2slA9%40paquier.xyz
Discussion: https://www.postgresql.org/message-id/ZO0fgDwVw2SUJiZx@paquier.xyz#482670177eb4eaf4c9f03c1eed963e5f
Backpatch-through: 13
src/backend/postmaster/postmaster.c