]> git.ipfire.org Git - people/arne_f/kernel.git/commit
cifs/smb3: Fix data inconsistent when zero file range
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Tue, 23 Jun 2020 11:31:54 +0000 (07:31 -0400)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:03 +0000 (15:38 -0400)
commita174c8680117a17b30a8c54b3f2a62d5eff8cfe5
treef9d9f5281379da882f7864d246459743698f0465
parentc602de22d93b0134bee32cf334bd3220552dba75
cifs/smb3: Fix data inconsistent when zero file range

[ Upstream commit 6b69040247e14b43419a520f841f2b3052833df9 ]

CIFS implements the fallocate(FALLOC_FL_ZERO_RANGE) with send SMB
ioctl(FSCTL_SET_ZERO_DATA) to server. It just set the range of the
remote file to zero, but local page cache not update, then the data
inconsistent with server, which leads the xfstest generic/008 failed.

So we need to remove the local page caches before send SMB
ioctl(FSCTL_SET_ZERO_DATA) to server. After next read, it will
re-cache it.

Fixes: 30175628bf7f5 ("[SMB3] Enable fallocate -z support for SMB3 mounts")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Cc: stable@vger.kernel.org # v3.17
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/smb2ops.c