]> git.ipfire.org Git - people/ms/linux.git/commit
net: Potential null skb->dev dereference
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 30 Mar 2010 04:33:28 +0000 (21:33 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 Apr 2010 23:02:10 +0000 (16:02 -0700)
commita1c9d89a98cbbc52ead6c44bb0c31eaaa37c5770
tree5980466b4e252d9082adfce04297ab19138fdf43
parent8c96206544955131f6d7cef09371950f34ebca5a
net: Potential null skb->dev dereference

[ Upstream commit 0641e4fbf2f824faee00ea74c459a088d94905fd ]

When doing "ifenslave -d bond0 eth0", there is chance to get NULL
dereference in netif_receive_skb(), because dev->master suddenly becomes
NULL after we tested it.

We should use ACCESS_ONCE() to avoid this (or rcu_dereference())

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/netdevice.h
net/8021q/vlan_core.c
net/core/dev.c