]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Backpatch nbtree page deletion hardening.
authorPeter Geoghegan <pg@bowt.ie>
Mon, 5 Sep 2022 18:20:01 +0000 (11:20 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Mon, 5 Sep 2022 18:20:01 +0000 (11:20 -0700)
commita228cca46d7da9783e1b49ae6f1b6cc2fe338bcc
treec96794b18711f7f3e5b006325426d1768baf7bbc
parent1630cad74092bf7af277762a22cc2605bd0bd5b6
Backpatch nbtree page deletion hardening.

Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy
opclasses.  VACUUM's inability to locate a to-be-deleted page's downlink
in the parent page was logged instead of throwing an error.  VACUUM
could just press on with vacuuming the index, and vacuuming the table as
a whole.

There are now anecdotal reports of this error causing problems that were
much more disruptive than the underlying index corruption ever could be.
Anything that makes VACUUM unable to make forward progress against one
table/index ultimately risks making the system enter xidStopLimit mode.
There is no good reason to take any chances here, so backpatch the
hardening commit.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm9HR6Pow=t-iQa57zT8qmX6_M4h14F-pTtb=xFDW5FBA@mail.gmail.com
Backpatch: 10-13 (all supported versions that lacked the hardening)
src/backend/access/nbtree/nbtpage.c